[WIP] ✨ Create kube-state-metrics configuration from markers #2310

chrischdi · 2023-08-31T12:44:10Z

What this PR does / why we need it:

Makes use of kube-state-metrics PR kubernetes/kube-state-metrics#2014 to generate the configuration for the CRD metrics.

TODO:

wait for feat(metric-gen): Implement metric-gen tool to create custom resource configuration from markers kubernetes/kube-state-metrics#2014 to merge
squash

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2061

k8s-ci-robot · 2023-08-31T12:44:15Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from chrischdi. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sbueringer

Just did a high-level review. So far pretty nice. Thx for working on this!

config/metrics/crd-metrics-config.yaml

apis/v1beta1/vspherecluster_types.go

sbueringer · 2023-09-01T12:26:50Z

hack/go-tools-build.sh

-CAPI_HACK_TOOLS="sigs.k8s.io/cluster-api/hack/tools"
+export GOWORK="off"
+
+GOMOD_REPLACE=${GOMOD_REPLACE:=}


nit: A bit of godoc around these variables would be good

Makefile

sbueringer · 2023-09-01T12:30:48Z

Makefile

 $(RELEASE_NOTES): # Build release-notes.
-	GOBIN=$(TOOLS_BIN_DIR) $(GO_TOOLS_BUILD) $(RELEASE_NOTES_PKG) $(RELEASE_NOTES_BIN) $(RELEASE_NOTES_VER)
+	GOBIN=$(TOOLS_BIN_DIR) GOMOD_REQUIRE="$(RELEASE_NOTES_MOD_REQUIRE)" $(GO_TOOLS_BUILD) $(RELEASE_NOTES_PKG) $(RELEASE_NOTES_BIN) $(RELEASE_NOTES_VER)


Suggested change

GOBIN=$(TOOLS_BIN_DIR) GOMOD_REQUIRE="$(RELEASE_NOTES_MOD_REQUIRE)" $(GO_TOOLS_BUILD) $(RELEASE_NOTES_PKG) $(RELEASE_NOTES_BIN) $(RELEASE_NOTES_VER)

GOBIN=$(TOOLS_BIN_DIR) GO_MOD_REQUIRE="$(RELEASE_NOTES_MOD_REQUIRE)" $(GO_TOOLS_BUILD) $(RELEASE_NOTES_PKG) $(RELEASE_NOTES_BIN) $(RELEASE_NOTES_VER)

I think (?)

Nope. Here we need GO_MOD_REQUIRE, otherwise the commands would have a failure and the script won't finish.

My suggestion is to rename the variable :) Sorry wasn't pretty clear

codecov-commenter · 2023-09-11T10:45:21Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.14%. Comparing base (f2ce04d) to head (4810df7).
Report is 1014 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2310      +/-   ##
==========================================
- Coverage   50.26%   50.14%   -0.13%     
==========================================
  Files          87       87              
  Lines        8041     8041              
==========================================
- Hits         4042     4032      -10     
- Misses       3674     3681       +7     
- Partials      325      328       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

k8s-ci-robot · 2023-09-13T00:40:06Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-triage-robot · 2024-01-21T14:20:56Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2024-02-25T18:35:27Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

chrischdi · 2024-02-26T08:24:37Z

/remove-lifecycle rotten

k8s-ci-robot · 2024-04-08T16:10:48Z

@chrischdi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-provider-vsphere-e2e-main-oldpreset	`4e8c13f`	link	true	`/test pull-cluster-api-provider-vsphere-e2e-main-oldpreset`
pull-cluster-api-provider-vsphere-e2e-blocking-main	`4810df7`	link	true	`/test pull-cluster-api-provider-vsphere-e2e-blocking-main`
pull-cluster-api-provider-vsphere-e2e-supervisor-blocking-main	`4810df7`	link	true	`/test pull-cluster-api-provider-vsphere-e2e-supervisor-blocking-main`
pull-cluster-api-provider-vsphere-e2e-govmomi-blocking-main	`4810df7`	link	true	`/test pull-cluster-api-provider-vsphere-e2e-govmomi-blocking-main`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-triage-robot · 2024-07-17T18:06:38Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2024-09-05T22:04:31Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 31, 2023

k8s-ci-robot requested review from srm09 and vrabbi August 31, 2023 12:44

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 31, 2023

sbueringer reviewed Sep 1, 2023

View reviewed changes

chrischdi force-pushed the pr-exp-metric-gen branch 3 times, most recently from d1f970a to e46b1b0 Compare September 1, 2023 13:16

chrischdi force-pushed the pr-exp-metric-gen branch from 68d8c32 to e9806cf Compare September 11, 2023 11:07

kubernetes-sigs deleted a comment from k8s-ci-robot Sep 11, 2023

first set of metrics

4810df7

chrischdi force-pushed the pr-exp-metric-gen branch from cf76710 to 4810df7 Compare September 12, 2023 09:54

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 12, 2023

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 21, 2024

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 25, 2024

k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Feb 26, 2024

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 17, 2024

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] ✨ Create kube-state-metrics configuration from markers #2310

[WIP] ✨ Create kube-state-metrics configuration from markers #2310

chrischdi commented Aug 31, 2023 •

edited

Loading

k8s-ci-robot commented Aug 31, 2023

sbueringer left a comment

sbueringer Sep 1, 2023 •

edited

Loading

sbueringer Sep 1, 2023

chrischdi Sep 1, 2023

sbueringer Sep 1, 2023

chrischdi Sep 1, 2023

codecov-commenter commented Sep 11, 2023 •

edited by codecov bot

Loading

k8s-ci-robot commented Sep 13, 2023

k8s-triage-robot commented Jan 21, 2024

k8s-triage-robot commented Feb 25, 2024

chrischdi commented Feb 26, 2024

k8s-ci-robot commented Apr 8, 2024

k8s-triage-robot commented Jul 17, 2024

k8s-triage-robot commented Sep 5, 2024

	GOBIN=$(TOOLS_BIN_DIR) GOMOD_REQUIRE="$(RELEASE_NOTES_MOD_REQUIRE)" $(GO_TOOLS_BUILD) $(RELEASE_NOTES_PKG) $(RELEASE_NOTES_BIN) $(RELEASE_NOTES_VER)
	GOBIN=$(TOOLS_BIN_DIR) GO_MOD_REQUIRE="$(RELEASE_NOTES_MOD_REQUIRE)" $(GO_TOOLS_BUILD) $(RELEASE_NOTES_PKG) $(RELEASE_NOTES_BIN) $(RELEASE_NOTES_VER)

[WIP] ✨ Create kube-state-metrics configuration from markers #2310

Are you sure you want to change the base?

[WIP] ✨ Create kube-state-metrics configuration from markers #2310

Conversation

chrischdi commented Aug 31, 2023 • edited Loading

k8s-ci-robot commented Aug 31, 2023

sbueringer left a comment

Choose a reason for hiding this comment

sbueringer Sep 1, 2023 • edited Loading

Choose a reason for hiding this comment

sbueringer Sep 1, 2023

Choose a reason for hiding this comment

chrischdi Sep 1, 2023

Choose a reason for hiding this comment

sbueringer Sep 1, 2023

Choose a reason for hiding this comment

chrischdi Sep 1, 2023

Choose a reason for hiding this comment

codecov-commenter commented Sep 11, 2023 • edited by codecov bot Loading

Codecov Report

k8s-ci-robot commented Sep 13, 2023

k8s-triage-robot commented Jan 21, 2024

k8s-triage-robot commented Feb 25, 2024

chrischdi commented Feb 26, 2024

k8s-ci-robot commented Apr 8, 2024

k8s-triage-robot commented Jul 17, 2024

k8s-triage-robot commented Sep 5, 2024

chrischdi commented Aug 31, 2023 •

edited

Loading

sbueringer Sep 1, 2023 •

edited

Loading

codecov-commenter commented Sep 11, 2023 •

edited by codecov bot

Loading